Skip to content

[vinxi] fix use server directive on windows#1109

Merged
ryansolid merged 1 commit intosolidjs:vinxifrom
edivados:vinxi-use-server
Nov 3, 2023
Merged

[vinxi] fix use server directive on windows#1109
ryansolid merged 1 commit intosolidjs:vinxifrom
edivados:vinxi-use-server

Conversation

@edivados
Copy link
Contributor

@edivados edivados commented Nov 3, 2023 •
edited
Loading

PR Type

  • Bugfix

What is the current behavior?

Fails to load server-runtime.jsx because the path is outputed with unescaped backslashes.

21:42:37 [vite] Pre-transform error: Failed to load url C:UsersDavideDesktopsolid-startpackagesstart-newconfigserver-runtime.jsx (resolved id: C:UsersDavideDesktopsolid-startpackagesstart-newconfigserver-runtime.jsx) in C:/Users/Davide/Desktop/solid-start/examples/hackernews/src/lib/api.ts. Does the file exist?
21:42:37 [vite] Error when evaluating SSR module /src/lib/api.ts: failed to import "C:UsersDavideDesktopsolid-startpackagesstart-newconfigserver-runtime.jsx"
|- Error: Failed to load url C:UsersDavideDesktopsolid-startpackagesstart-newconfigserver-runtime.jsx (resolved id: C:UsersDavideDesktopsolid-startpackagesstart-newconfigserver-runtime.jsx) in C:/Users/Davide/Desktop/solid-start/examples/hackernews/src/lib/api.ts. Does the file exist?
    at loadAndTransform (file:///C:/Users/Davide/Desktop/solid-start/node_modules/.pnpm/vite@5.0.0-beta.7/node_modules/vite/dist/node/chunks/dep-7af400e9.js:55807:21)

What is the new behavior?

Normalizing path to / forward slash.

Other information

@edivados edivados changed the title fix use server directive on windows [vinxi] fix use server directive on windows Nov 3, 2023
@ryansolid ryansolid merged commit 9d65f3e into solidjs:vinxi Nov 3, 2023
@ryansolid
Copy link
Member

ryansolid commented Nov 3, 2023

Thanks

@edivados edivados deleted the vinxi-use-server branch November 4, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edivados @ryansolid